fix(agents-api): Fixed tests for models and queries #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Tomer <[email protected]>
* **agents-api/tests/test_agent_queries.py** - Update import statements to reflect the new location of the model functions - Update function calls to the new location of the model functions - Add `from agents_api.autogen.openapi_model import Agent` back * **agents-api/tests/test_docs_queries.py** - Update import statements to reflect the new location of the model functions * **agents-api/tests/test_entry_queries.py** - Update import statements to reflect the new location of the model functions * **agents-api/tests/test_execution_queries.py** - Update import statements to reflect the new location of the model functions * **agents-api/tests/test_session_queries.py** - Update import statements to reflect the new location of the model functions * **agents-api/tests/test_task_queries.py** - Update import statements to reflect the new location of the model functions * **agents-api/tests/test_tool_queries.py** - Update import statements to reflect the new location of the model functions * **agents-api/tests/test_user_queries.py** - Update import statements to reflect the new location of the model functions
…eries.py` Update tests in `test_agent_queries.py` to use existing models and queries * Replace `agent.create_agent` with `create_agent` * Replace `agent.delete_agent` with `delete_agent` * Replace `agent.get_agent` with `get_agent` * Replace `agent.list_agents` with `list_agents` * Replace `agent.update_agent` with `update_agent` Update tests in `test_session_queries.py` to use existing models and queries * Import `Session` from `agents_api.autogen.openapi_model` Update tests in `test_task_queries.py` to use existing models and queries * Replace `CreateTaskRequest`, `DeleteTaskRequest`, `GetTaskRequest`, `ListTasksRequest`, `UpdateTaskRequest` with dictionaries Update tests in `test_tool_queries.py` to use existing models and queries * Replace `FunctionDef` with dictionaries Update tests in `test_user_queries.py` to use existing models and queries * Replace `agents_api.autogen.openapi_model` with `agents_api.autogen.Users`
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ad27ec0 in 1 minute and 3 seconds
More details
- Looked at
3034lines of code in26files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. agents-api/agents_api/models/agent/delete_agent.py:29
- Draft comment:
The HTTP status code for "developer not found or doesn't own resource" should be 404 (Not Found) instead of 403 (Forbidden) as it directly relates to the inability to locate a resource (developer or agent) specified by the client.
detail="developer not found or doesnt own resource", status_code=404
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
2. agents-api/agents_api/models/agent/get_agent.py:24
- Draft comment:
The HTTP status code for "developer not found or doesn't own resource" should be 404 (Not Found) instead of 403 (Forbidden) as it directly relates to the inability to locate a resource (developer or agent) specified by the client.
detail="developer not found or doesnt own resource", status_code=404
- Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_JHxoYrURlNmRAKNo
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeleteDocRequestimport and related tests fromtest_docs_queries.pySummary:
Refactored and relocated test files for
agents-api, updated model function locations, and modified exception handling and query construction.Key points:
DeleteDocRequestimport and related tests fromagents-api/agents_api/models/docs/test_docs_queries.py.create_agent.py,delete_agent.py,get_agent.py, and others.delete_doc.py,create_entries.py,create_execution.py, and others.agents-api/tests/fixtures.pyto support new test setup.Generated with ❤️ by ellipsis.dev